fix linting by using new maligned linter instead of aligncheck#659
Merged
smira merged 2 commits intoaptly-dev:masterfrom Oct 31, 2017
Merged
fix linting by using new maligned linter instead of aligncheck#659smira merged 2 commits intoaptly-dev:masterfrom
smira merged 2 commits intoaptly-dev:masterfrom
Conversation
upstream switched the alignment check backend and in doing so fails to run if the old backend is defined in the config. also skip alignment linting on a struct we use for byte decoding as we have no choice in its member order.
'E722 do not use bare except' wants us not to use except without type restriction as it catches everything and the kitchen sink. Since we use them to catch exceptions in test cases this is intentional as we implement general purpose error handling on test failure there.
1 task
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upstream switched the alignment check backend and in doing so fails to run
if the old backend is defined in the config.
also skip alignment linting on a struct we use for byte decoding as we have
no choice in its member order.
Also see alecthomas/gometalinter@90d9878
Fixes all PRs failing on linting