Skip to content

Conversation

@taichi-ishitani
Copy link
Contributor

I cleaned up unit test errors caused by frozen string literal.

Also I introduced CI regression test with Travis CI.
On the CI regression test, the gem is tested with following rubies:

  • 1.8.7
  • 1.9.2
  • 1.9.3
  • 2.0.0
  • 2.1.0
  • 2.2.0
  • 2.3.0
  • 2.4.0
  • 2.5.0
    • with --frozen-string-literal
  • 2.6.0
    • with --frozen-string-literal

Note:
Ruby 2.3 and 2.4 support frozen string literal but it seems that standard libraries for these version do not support the feature enough.
Therefore, frozen string literal is not enabled for CI regression test with Ruby 2.3 and 2.4.

@aquasync
Copy link
Owner

aquasync commented Mar 6, 2019

Looks good, thanks!

@aquasync aquasync merged commit ba3c7db into aquasync:master Mar 6, 2019
@taichi-ishitani
Copy link
Contributor Author

Hi @aquasync ,
Thank you for merging my PR!

BTW, when will you release the latest ruby-ole gem which includes my PR?
My gem depends on the ruby-ole gem and I'm using my forked version of ruby-ole because of the frozen string literal issue.
I'd like to use the official ruby-ole gem instead of my forked version.

@aquasync
Copy link
Owner

No worries. I've released 1.2.12.2 now.

@taichi-ishitani
Copy link
Contributor Author

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants