Skip to content

fix metadata #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
novaknole merged 2 commits into from
Feb 28, 2023
Merged

fix metadata #303

novaknole merged 2 commits into from
Feb 28, 2023

Conversation

@novaknole
Copy link
Contributor

@novaknole novaknole commented Feb 28, 2023

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: ID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

Rekard0
Rekard0 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, it is nice that the deployer still hold all powers to re set the metadata after registering.

@novaknole novaknole merged commit f4df734 into develop Feb 28, 2023
@novaknole novaknole deleted the fix/deploy-dao-metadata branch February 28, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mathewmeconry mathewmeconry mathewmeconry approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contracts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@novaknole @mathewmeconry @Rekard0