-
Notifications
You must be signed in to change notification settings - Fork 54
F/ OS-387 add protocol version #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
heueristik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should include the protocolVersion function in every (most derived) protocol contract we maintain. I think it would be beneficial to incrementally add it to all framework contracts with every upgrade we must make.
In this protocol upgrade, I would add it to DAOFactory as well for convenience purposes (although DAOFactory has daoBase and we can, with more effort, get it also from there).
We should discuss why this is needed in a meeting.
Description
Please include a summary of the change and be sure you follow the contributions rules we do provide here
Task: OS-387
Type of change
Checklist:
CHANGELOG.mdfile in the root folder.