Skip to content

Added Test to Check Flow Output#1

Closed
0xcaff wants to merge 1 commit intoarahansen:flow-typesfrom
0xcaff:flow-types
Closed

Added Test to Check Flow Output#1
0xcaff wants to merge 1 commit intoarahansen:flow-typesfrom
0xcaff:flow-types

Conversation

@0xcaff
Copy link
Copy Markdown

@0xcaff 0xcaff commented Jan 5, 2018

Hey,

I've added a test to check whether the output generated by this code is valid according to flow. It seems that currently, the Node type occurs twice.

      163:   export type Node = {
                         ^^^^ Node. name is already bound
      158:   type Node = Film | Species | Planet | Person | Starship | Vehicle;
                  ^^^^ type Node

Thanks for this!

@0xcaff
Copy link
Copy Markdown
Author

0xcaff commented Jan 5, 2018

I've located the duplicate in the snapshot.

/**
description: An object with an ID
*/
type Node = Film | Species | Planet | Person | Starship | Vehicle;
/**
description: An object with an ID
*/
export type Node = {
__typename: \\"Node\\";
/**
description: The id of the object.
*/
id: string;
}

@0xcaff
Copy link
Copy Markdown
Author

0xcaff commented Aug 20, 2018

Closing, as I no longer use use gql2ts.

@0xcaff 0xcaff closed this Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant