Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the obsolete parses simply one big obsolete comment with all the obsolete data in it (e.g. msgid and msgstr).
This pull requests adds functionality to the Entry class to parse the content of the obsolete comment by simply sending it without the obsolete markers to the simple_po_parser.
One caveat: The simple_po_parser is not 100% strict and will not raise an error on parsing an invalid obsolete entry (e.g. an obsolete without a msgstr), even though msgcat will. With this addition the PoParser will fail on such invalid po entries. I don't think this is a bad thing as the gettext utilities throw an error too.