Force the tokenizer to load files in utf-8#20
Merged
arashm merged 1 commit intoarashm:masterfrom Jun 22, 2017
Merged
Conversation
Owner
|
Thank you! 👍 |
Owner
|
On version 3.2.0 I deprecated this behavior and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes about after trying to use PoParser on the Windows command line which has codepage 850 as its default encoding.
Most modern *ix will set LC_ALL et.al. to a reasonable UTF-* encoding thus you won't notice that reading a file with File.open(bla,'r') will just try to use the terminal's encoding and thus fail miserably and spectacularly.
Given that .po files are usually meant for internationalisation it is a safe assumption that the contents will not be limited to the old 850 codepage and that UTF-8 is a reasonable default.
This is an emergency patch to make it usable on Windows. To fix it permanently I would restructure the library to not do any file IO interactions, instead to expect the content of the .po file as a string.
You then let the user decide how to load the file. Alternately, provide a few convenience methods for specific encodings (e.g. PoParser.load_utf8(po_file) or some such)