Skip to content

Many small refactoring / clean-ups / memory savings#2465

Merged
thorstenhater merged 22 commits intoarbor-sim:masterfrom
thorstenhater:qa/simulation-remove-redundant-information
Aug 14, 2025
Merged

Many small refactoring / clean-ups / memory savings#2465
thorstenhater merged 22 commits intoarbor-sim:masterfrom
thorstenhater:qa/simulation-remove-redundant-information

Conversation

@thorstenhater
Copy link
Copy Markdown
Contributor

@thorstenhater thorstenhater commented Jun 23, 2025

  • Fix iterator issues using concepts
  • Remove group index from the simulation object.
  • clean up / refactoring.

@thorstenhater thorstenhater changed the title Qa/simulation remove redundant information Many small refactoring / clean-ups / memory savings Jun 26, 2025
@thorstenhater thorstenhater requested a review from ibanezbm July 2, 2025 11:04
ibanezbm
ibanezbm reviewed Jul 12, 2025
View reviewed changes
Comment thread arbor/fvm_layout.cpp Outdated
global_dflt.ion_data.end());
for (const auto& [ion, dflt]: global_dflt.ion_data) {
auto& data = ion_data[ion];
if (!data.diffusivity) data.diffusivity = data.diffusivity;
Copy link
Copy Markdown
Collaborator

@ibanezbm ibanezbm Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in PR 2468

ibanezbm
ibanezbm reviewed Jul 12, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ibanezbm ibanezbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same error appears in arbor/fvm_layout.cpp, line 1078, as in PR #2468. Everything else looks perfect.

ibanezbm
ibanezbm approved these changes Jul 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ibanezbm ibanezbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything OK

@thorstenhater thorstenhater merged commit c267899 into arbor-sim:master Aug 14, 2025
28 of 29 checks passed
@ibanezbm ibanezbm mentioned this pull request Sep 3, 2025
Merged
thorstenhater pushed a commit that referenced this pull request Sep 4, 2025
@ibanezbm
Fix GPU test issues (#2479)
ef667f6 
This pull request fixes issues in the GPU tests introduced in PR #2465
and PR #2264.

Changes include:
- Fixed the event stream GPU test implementation.
- Fixed the handling of the "dt" parameter in the serdes test.

These fixes ensure that the GPU tests run reliably again.
@thorstenhater thorstenhater mentioned this pull request Apr 15, 2026
Merged
thorstenhater added a commit that referenced this pull request Apr 16, 2026
@thorstenhater
final clean-up before v0.12 (#2504)
aa8f708 
# Preliminary release notes for v0.12

## What's Changed
* V0.11.0 rc by @thorstenhater in
#2454
* Release finalisation by @thorstenhater in
#2455
* CSCS CI by @thorstenhater in
#2448
* Re-factor connection setup and event dispatch. by @thorstenhater in
#2449
* Add tiled busyring by @thorstenhater in
#2456
* Fill in a missing part of the docs by @thorstenhater in
#2462
* Major Optimisations in Label Resolution by @thorstenhater in
#2458
* Refactor domain decomposition by @thorstenhater in
#2457
* Add an escape hatch to label resolution by @thorstenhater in
#2459
* Fix crash on probding elided values by @thorstenhater in
#2466
* Only store PRNG data if needed by @thorstenhater in
#2467
* 🐍 Polish `label_dict` by @thorstenhater in
#2451
* use better builtins for double max/min by @thorstenhater in
#2469
* Remove typed map and refactor cable cell by @thorstenhater in
#2468
* Many small refactoring / clean-ups / memory savings by @thorstenhater
in #2465
* Bump pb11 to latest major version by @thorstenhater in
#2475
* Fix GPU test issues by @ibanezbm in
#2479
* Align versions by @thorstenhater in
#2481
* Add probing of eX. by @thorstenhater in
#2478
* Add trivial compiler test by @thorstenhater in
#2488
* Replace MPI_Allgatherv with MPI_Alltoallv for communication pattern by
@ibanezbm in #2460
* Use CBRNG in schedules. by @thorstenhater in
#2386
* Update year 🎉 by @thorstenhater in
#2491
* Don't use deprecated numpy functions by @thorstenhater in
#2490
* Co-simulation tutorial by @thorstenhater in
#2492
* Nested timers by @marvinKaster in
#2486
* Clean-up iclamp interface by @thorstenhater in
#2494
* Fix override by @thorstenhater in
#2493
* Better use of __restrict__ by @thorstenhater in
#2476
* Add AdEx cells. by @thorstenhater in
#2230
* units in cv policy by @thorstenhater in
#2495
* Flat map in mechanism description for 1.5x speed-up in synapse
creation by @thorstenhater in
#2501
* Perf/compress contiguous by @thorstenhater in
#2470
* Allow more SWC files in the parser by @thorstenhater in
#2471
* STDP case for busyring benchmark by @jlubo in
#2489
* round robin load balance by @thorstenhater in
#2500

## New Contributors
* @ibanezbm made their first contribution in
#2479
* @marvinKaster made their first contribution in
#2486

**Full Changelog**:
v0.11.0...v0.12.0
@thorstenhater thorstenhater mentioned this pull request Apr 16, 2026
Merged
thorstenhater added a commit that referenced this pull request Apr 17, 2026
@thorstenhater
Release v0.12 (#2506)
87a39d4 
# Release notes

This release constitutes a major improvement in terms of parallel
performance
by replacing the underlying MPI algorithm (see our paper at IPDPS'26)
and
setup time by improving label resolution and adding the access to raw
labels.
On the functional side, we introduced AdEx cells, added a new load
balancing
method, and probes for the reversal potential.

## What's Changed
* V0.11.0 rc by @thorstenhater in
#2454
* Release finalisation by @thorstenhater in
#2455
* CSCS CI by @thorstenhater in
#2448
* Re-factor connection setup and event dispatch. by @thorstenhater in
#2449
* Add tiled busyring by @thorstenhater in
#2456
* Fill in a missing part of the docs by @thorstenhater in
#2462
* Major Optimisations in Label Resolution by @thorstenhater in
#2458
* Refactor domain decomposition by @thorstenhater in
#2457
* Add an escape hatch to label resolution by @thorstenhater in
#2459
* Fix crash on probding elided values by @thorstenhater in
#2466
* Only store PRNG data if needed by @thorstenhater in
#2467
* 🐍 Polish `label_dict` by @thorstenhater in
#2451
* use better builtins for double max/min by @thorstenhater in
#2469
* Remove typed map and refactor cable cell by @thorstenhater in
#2468
* Many small refactoring / clean-ups / memory savings by @thorstenhater
in #2465
* Bump pb11 to latest major version by @thorstenhater in
#2475
* Fix GPU test issues by @ibanezbm in
#2479
* Align versions by @thorstenhater in
#2481
* Add probing of eX. by @thorstenhater in
#2478
* Add trivial compiler test by @thorstenhater in
#2488
* Replace MPI_Allgatherv with MPI_Alltoallv for communication pattern by
@ibanezbm in #2460
* Use CBRNG in schedules. by @thorstenhater in
#2386
* Update year 🎉 by @thorstenhater in
#2491
* Don't use deprecated numpy functions by @thorstenhater in
#2490
* Co-simulation tutorial by @thorstenhater in
#2492
* Nested timers by @marvinKaster in
#2486
* Clean-up iclamp interface by @thorstenhater in
#2494
* Fix override by @thorstenhater in
#2493
* Better use of __restrict__ by @thorstenhater in
#2476
* Add AdEx cells. by @thorstenhater in
#2230
* units in cv policy by @thorstenhater in
#2495
* Flat map in mechanism description for 1.5x speed-up in synapse
creation by @thorstenhater in
#2501
* Perf/compress contiguous by @thorstenhater in
#2470
* Allow more SWC files in the parser by @thorstenhater in
#2471
* STDP case for busyring benchmark by @jlubo in
#2489
* round robin load balance by @thorstenhater in
#2500

## New Contributors
* @ibanezbm made their first contribution in
#2479
* @marvinKaster made their first contribution in
#2486

**Full Changelog**:
v0.11.0...v0.12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibanezbm ibanezbm ibanezbm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thorstenhater @ibanezbm