You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As was foreseen I ran into issues with npm workspaces (see #26). This PR removes them and instead uses docker to manage building & running all of the example apps
I was part-way down the path of writing a tiny cli tool that would install node_modules and build each example before I realized docker would be a much easier solution. This is not yet the most ergonomic solution or complete but certainly feels like a step in the right direction.
For this PR I've also intentionally made minimal changes to the publishing just to keep things moving. I plan to follow up and drastically improve on this. I have some of that code written from the cli tool I mentioned.
This approach has the added benefit that each of our examples has a fully functional docker-compose setup for customers to quickly spin up and play with. It is not yet documented.
For this PR please test:
docker compose build runs for you
docker compose up either warns of missing .env files or comes up
Next steps: Take a moment to review the security alert
above. Review the linked package source code to understand the potential
risk. Ensure the package is not malicious before proceeding. If you're
unsure how to proceed, reach out to your security team or ask the Socket
team for help at support@socket.dev.
Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.
Mark the package as acceptable risk. To ignore this alert only
in this pull request, reply with the comment
@SocketSecurity ignore npm/caniuse-lite@1.0.30001731. You can
also ignore all packages with @SocketSecurity ignore-all.
To ignore an alert for all future pull requests, use Socket's Dashboard to
change the triage state of this alert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26
Closes #28
As was foreseen I ran into issues with npm workspaces (see #26). This PR removes them and instead uses docker to manage building & running all of the example apps
I was part-way down the path of writing a tiny cli tool that would install node_modules and build each example before I realized docker would be a much easier solution. This is not yet the most ergonomic solution or complete but certainly feels like a step in the right direction.
For this PR I've also intentionally made minimal changes to the publishing just to keep things moving. I plan to follow up and drastically improve on this. I have some of that code written from the cli tool I mentioned.
This approach has the added benefit that each of our examples has a fully functional docker-compose setup for customers to quickly spin up and play with. It is not yet documented.
For this PR please test:
docker compose buildruns for youdocker compose upeither warns of missing.envfiles or comes up