Skip to content

Comments

chore: Add Dockerfiles and compose configuration#30

Merged
qw-in merged 3 commits intomainfrom
quinn/docker-not-workspaces
Aug 5, 2025
Merged

chore: Add Dockerfiles and compose configuration#30
qw-in merged 3 commits intomainfrom
quinn/docker-not-workspaces

Conversation

@qw-in
Copy link
Member

@qw-in qw-in commented Aug 1, 2025

Closes #26
Closes #28

As was foreseen I ran into issues with npm workspaces (see #26). This PR removes them and instead uses docker to manage building & running all of the example apps

I was part-way down the path of writing a tiny cli tool that would install node_modules and build each example before I realized docker would be a much easier solution. This is not yet the most ergonomic solution or complete but certainly feels like a step in the right direction.

For this PR I've also intentionally made minimal changes to the publishing just to keep things moving. I plan to follow up and drastically improve on this. I have some of that code written from the cli tool I mentioned.

This approach has the added benefit that each of our examples has a fully functional docker-compose setup for customers to quickly spin up and play with. It is not yet documented.

For this PR please test:

  1. docker compose build runs for you
  2. docker compose up either warns of missing .env files or comes up

@qw-in qw-in requested review from a team August 1, 2025 22:47
@qw-in qw-in self-assigned this Aug 1, 2025
@socket-security
Copy link

socket-security bot commented Aug 1, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

@socket-security
Copy link

socket-security bot commented Aug 1, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
caniuse-lite@1.0.30001731 has a License Policy Violation.

License: CC-BY-4.0 (npm metadata)

License: CC-BY-4.0 (package/LICENSE)

License: CC-BY-4.0 (package/package.json)

From: examples/nestjs/package-lock.jsonnpm/@nestjs/cli@11.0.7npm/caniuse-lite@1.0.30001731

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/caniuse-lite@1.0.30001731. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@qw-in qw-in merged commit a285c4e into main Aug 5, 2025
2 checks passed
@qw-in qw-in deleted the quinn/docker-not-workspaces branch August 5, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dockerfile & compose configuration Remove npm workspaces

2 participants