Conversation
…luentAssertions to test project. Fixes ardalis#58
|
Closes #61 |
| .And() | ||
| .AreNot([typeof(AssemblyInfo), typeof(NewModuleModuleServiceRegistrar)]) | ||
| .And() | ||
| .DoNotResideInNamespace("Modulith.NewModule.Data.Migrations") |
There was a problem hiding this comment.
I understand the need for this. but since the template does not include migrations yet. I think this change should have been added with a template that has migrations. I'll add an issue to include this
There was a problem hiding this comment.
Just trying make it through Techorama :)
There was a problem hiding this comment.
I guess the issue is, if you use this template....a very natural progression would be to add EF Core.
Just trying to guide the developer into the pit of success
| { | ||
| if (!TryGetServiceRegistrationMethod(logger, assembly, out var method)) | ||
| { | ||
| logger.LogError("🛑 An error occurred registering services for assembly: '{assembly}'. Skipping registration", assembly.GetName()); |
There was a problem hiding this comment.
This error was generating some noise because some of the assemblies found didn't actually need to be registered and as a result the registration will fail. In a future release we should add the error back and fix the actual logic of finding the assemblies
There was a problem hiding this comment.
If you want to add the log back in and turn it to info or debug?
A natural progression of using a Contract in a module shouldn't cause errors.
3 participants
@david-acm @ardalis