Cleaned up a few warnings and fixed strict-aliasing #1352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up warnings about unsigned types, unused variables, and declarations. Explicitly declare char as signed for cases when compiling with -funsigned-char. Fixed strict-aliasing issues in IPAddress.h. Fixed array overrun where EXTERNAL_NUM_INTERRUPTS was defined too small.
Local variables can't be declared with PROGMEM and don't need to be when pointing to a PROGMEM address.
This resolves issue arduino#1356 and add the ability for the Arduino IDE to detect the amount of RAM allocated to a sketch and compare that to the available RAM on each board. If RAM is more than 90% full, it will fail on building since there is not enough free RAM for the heap and stack to use.
Author
|
I've migrated all changes to the ide-1.5.x branch and created #1399 for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up warnings about unsigned types, unused variables, and
declarations.
Explicitly declare char as signed for cases when compiling with
-funsigned-char.
Fixed strict-aliasing issues in IPAddress.h.
Fixed array overrun where EXTERNAL_NUM_INTERRUPTS was defined too small.