Do not save build_properties_custom.* preferences to disk #4853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added a commit
to cmaglie/arduino-builder
that referenced
this pull request
Apr 12, 2016
See arduino/Arduino#4702 See arduino/Arduino#4853 Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
Contributor
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4853-BUILD-551-linux32.tar.xz ℹ️ The |
Member
|
Tested and works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4702.
If a
--prefoption is passed into the IDE as a command line arg, then it is also saved in thepreferences.txt filewith abuild_properties_custom.prefix.For example:
arduino --pref "boardsmanager.additional.urls=http://arduino.esp8266.com/stable/package_esp8266com_index.json" --install-boards esp8266:esp8266will add the following line:
The main purpose of the
build_properties_custom.*properties is to pass in custom build properties to the Compiler. See Compiler.java. I think these parameters are not mean't to be persistent.