Added 'board details' #67

cmaglie · 2018-10-11T15:52:20Z

This should partially (or even totally) fix #45.

examples of output:

$ arduino-cli board details arduino:avr:nano
Board name: Arduino Nano                   

Option:     Processor                         cpu             
            ATmega328P                      ✔ cpu=atmega328   
            ATmega328P (Old Bootloader)       cpu=atmega328old
            ATmega168                         cpu=atmega168   

$ arduino-cli board details arduino:avr:nano:cpu=atmega328old
Board name: Arduino Nano                   

Option:     Processor                         cpu             
            ATmega328P                        cpu=atmega328   
            ATmega328P (Old Bootloader)     ✔ cpu=atmega328old
            ATmega168                         cpu=atmega168   

$ arduino-cli board details arduino:avr:nano --format json
{
  "Name": "Arduino Nano",
  "ConfigOptions": [
    {
      "Option": "cpu",
      "OptionLabel": "Processor",
      "Values": [
        {
          "Value": "atmega328",
          "ValueLabel": "ATmega328P",
          "Selected": true
        },
        {
          "Value": "atmega328old",
          "ValueLabel": "ATmega328P (Old Bootloader)"
        },
        {
          "Value": "atmega168",
          "ValueLabel": "ATmega168"
        }
      ]
    }
  ]
}

/cc @brusherru

brusherru · 2018-10-15T16:19:13Z

Just tested this on esp8266:esp8266:generic board.

There are some options without label (did not parsed well) for upload speed on different OS:

Option:     Upload Speed                             UploadSpeed                                                                
            115200                                 ✔ UploadSpeed=115200                                                         
            9600                                     UploadSpeed=9600                                                           
            57600                                    UploadSpeed=57600                                                          
            230400                                   UploadSpeed=230400                                                         
                                                     UploadSpeed=256000                                                         
            460800                                   UploadSpeed=460800                                                         
                                                     UploadSpeed=512000                                                         
            921600                                   UploadSpeed=921600

Cause boards.txt contains:

generic.menu.UploadSpeed.115200=115200
generic.menu.UploadSpeed.115200.upload.speed=115200
generic.menu.UploadSpeed.9600=9600
generic.menu.UploadSpeed.9600.upload.speed=9600
generic.menu.UploadSpeed.57600=57600
generic.menu.UploadSpeed.57600.upload.speed=57600
generic.menu.UploadSpeed.230400.linux=230400
generic.menu.UploadSpeed.230400.macosx=230400
generic.menu.UploadSpeed.230400.upload.speed=230400
generic.menu.UploadSpeed.256000.windows=256000
generic.menu.UploadSpeed.256000.upload.speed=256000
generic.menu.UploadSpeed.460800.linux=460800
generic.menu.UploadSpeed.460800.macosx=460800
generic.menu.UploadSpeed.460800.upload.speed=460800
generic.menu.UploadSpeed.512000.windows=512000
generic.menu.UploadSpeed.512000.upload.speed=512000
generic.menu.UploadSpeed.921600=921600
generic.menu.UploadSpeed.921600.upload.speed=921600

brusherru · 2018-10-15T16:22:41Z

output/table.go

+	for x := range average {
+		average[x] = average[x] / count[x]
+	}
+	// fmt.Println("COUNT:", count)


Stale code for debugging?

brusherru · 2018-10-15T16:25:53Z

Overall, awesome! 🙌

See: arduino#67 (comment) quote: There are some options without label (did not parsed well) for upload speed on different OS: Option: Upload Speed UploadSpeed 115200 ✔ UploadSpeed=115200 9600 UploadSpeed=9600 57600 UploadSpeed=57600 230400 UploadSpeed=230400 UploadSpeed=256000 460800 UploadSpeed=460800 UploadSpeed=512000 921600 UploadSpeed=921600 Cause boards.txt contains: generic.menu.UploadSpeed.115200=115200 generic.menu.UploadSpeed.115200.upload.speed=115200 generic.menu.UploadSpeed.9600=9600 generic.menu.UploadSpeed.9600.upload.speed=9600 generic.menu.UploadSpeed.57600=57600 generic.menu.UploadSpeed.57600.upload.speed=57600 generic.menu.UploadSpeed.230400.linux=230400 generic.menu.UploadSpeed.230400.macosx=230400 generic.menu.UploadSpeed.230400.upload.speed=230400 generic.menu.UploadSpeed.256000.windows=256000 generic.menu.UploadSpeed.256000.upload.speed=256000 generic.menu.UploadSpeed.460800.linux=460800 generic.menu.UploadSpeed.460800.macosx=460800 generic.menu.UploadSpeed.460800.upload.speed=460800 generic.menu.UploadSpeed.512000.windows=512000 generic.menu.UploadSpeed.512000.upload.speed=512000 generic.menu.UploadSpeed.921600=921600 generic.menu.UploadSpeed.921600.upload.speed=921600

cmaglie · 2018-10-19T10:51:22Z

There are some options without label (did not parsed well) for upload speed on different OS:

nice catch! This latest update should fix it, let's wait the CI to merge...

See arduino#45

This allows to show which option is selected with defaults or with different FQBNs. For example: $ arduino-cli board details arduino:avr:nano Board name: Arduino Nano Option: Processor cpu ATmega328P ✔ cpu=atmega328 ATmega328P (Old Bootloader) cpu=atmega328old ATmega168 cpu=atmega168 or: $ arduino-cli board details arduino:avr:nano:cpu=atmega328old Board name: Arduino Nano Option: Processor cpu ATmega328P cpu=atmega328 ATmega328P (Old Bootloader) ✔ cpu=atmega328old ATmega168 cpu=atmega168

See: arduino#67 (comment) quote: There are some options without label (did not parsed well) for upload speed on different OS: Option: Upload Speed UploadSpeed 115200 ✔ UploadSpeed=115200 9600 UploadSpeed=9600 57600 UploadSpeed=57600 230400 UploadSpeed=230400 UploadSpeed=256000 460800 UploadSpeed=460800 UploadSpeed=512000 921600 UploadSpeed=921600 Cause boards.txt contains: generic.menu.UploadSpeed.115200=115200 generic.menu.UploadSpeed.115200.upload.speed=115200 generic.menu.UploadSpeed.9600=9600 generic.menu.UploadSpeed.9600.upload.speed=9600 generic.menu.UploadSpeed.57600=57600 generic.menu.UploadSpeed.57600.upload.speed=57600 generic.menu.UploadSpeed.230400.linux=230400 generic.menu.UploadSpeed.230400.macosx=230400 generic.menu.UploadSpeed.230400.upload.speed=230400 generic.menu.UploadSpeed.256000.windows=256000 generic.menu.UploadSpeed.256000.upload.speed=256000 generic.menu.UploadSpeed.460800.linux=460800 generic.menu.UploadSpeed.460800.macosx=460800 generic.menu.UploadSpeed.460800.upload.speed=460800 generic.menu.UploadSpeed.512000.windows=512000 generic.menu.UploadSpeed.512000.upload.speed=512000 generic.menu.UploadSpeed.921600=921600 generic.menu.UploadSpeed.921600.upload.speed=921600

Race conditions tests are run on another CI system, before releases.

ArduinoBot · 2018-10-19T12:09:43Z

✅ Build completed.

⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-16-PR67-linux64.tar.bz2

⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-16-PR67-linux32.tar.bz2

⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-16-PR67-linuxarm.tar.bz2

⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-16-PR67-windows.zip

⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-16-PR67-osx.zip

ℹ️ To test this build:

Just replace arduino-cli binary with the provided one

brusherru

Awesome! 👍

See: #67 (comment) quote: There are some options without label (did not parsed well) for upload speed on different OS: Option: Upload Speed UploadSpeed 115200 ✔ UploadSpeed=115200 9600 UploadSpeed=9600 57600 UploadSpeed=57600 230400 UploadSpeed=230400 UploadSpeed=256000 460800 UploadSpeed=460800 UploadSpeed=512000 921600 UploadSpeed=921600 Cause boards.txt contains: generic.menu.UploadSpeed.115200=115200 generic.menu.UploadSpeed.115200.upload.speed=115200 generic.menu.UploadSpeed.9600=9600 generic.menu.UploadSpeed.9600.upload.speed=9600 generic.menu.UploadSpeed.57600=57600 generic.menu.UploadSpeed.57600.upload.speed=57600 generic.menu.UploadSpeed.230400.linux=230400 generic.menu.UploadSpeed.230400.macosx=230400 generic.menu.UploadSpeed.230400.upload.speed=230400 generic.menu.UploadSpeed.256000.windows=256000 generic.menu.UploadSpeed.256000.upload.speed=256000 generic.menu.UploadSpeed.460800.linux=460800 generic.menu.UploadSpeed.460800.macosx=460800 generic.menu.UploadSpeed.460800.upload.speed=460800 generic.menu.UploadSpeed.512000.windows=512000 generic.menu.UploadSpeed.512000.upload.speed=512000 generic.menu.UploadSpeed.921600=921600 generic.menu.UploadSpeed.921600.upload.speed=921600

Add checks for common misspellings of path base names

cmaglie self-assigned this Oct 11, 2018

cmaglie added the type: enhancement Proposed improvement label Oct 11, 2018

cmaglie added this to the next alpha milestone Oct 11, 2018

brusherru reviewed Oct 15, 2018

View reviewed changes

cmaglie force-pushed the board-details branch from 11441d0 to 6fdf4f5 Compare October 19, 2018 10:49

arduino deleted a comment from ArduinoBot Oct 19, 2018

cmaglie added 8 commits October 19, 2018 14:00

Added new experimental 'output' module to replace formatter

b6e032b

Added 'board details' command

b6322eb

See arduino#45

Improvements to output module

d92bfb9

Fixed error message in packagemanager.ResolveFQBN()

528f72a

Removed leftovers debugs

e770c8d

Make drone tests more quick

43bcb84

Race conditions tests are run on another CI system, before releases.

cmaglie force-pushed the board-details branch from 61f75df to 43bcb84 Compare October 19, 2018 12:08

brusherru approved these changes Oct 19, 2018

View reviewed changes

cmaglie merged commit 43bcb84 into arduino:master Oct 19, 2018

cmaglie deleted the board-details branch October 19, 2018 14:16

arduino deleted a comment from ArduinoBot Oct 19, 2018

per1234 added a commit that referenced this pull request Aug 9, 2021

Merge pull request #67 from arduino/per1234/misspelled-path-checks

7bd821e

Add checks for common misspellings of path base names

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Added 'board details' #67

Added 'board details' #67

Uh oh!

cmaglie commented Oct 11, 2018

Uh oh!

brusherru commented Oct 15, 2018 •

edited

Loading

Uh oh!

brusherru Oct 15, 2018

Uh oh!

cmaglie Oct 19, 2018

Uh oh!

brusherru commented Oct 15, 2018

Uh oh!

cmaglie commented Oct 19, 2018

Uh oh!

ArduinoBot commented Oct 19, 2018

Uh oh!

brusherru left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Added 'board details' #67

Added 'board details' #67

Uh oh!

Conversation

cmaglie commented Oct 11, 2018

Uh oh!

brusherru commented Oct 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brusherru Oct 15, 2018

Choose a reason for hiding this comment

Uh oh!

cmaglie Oct 19, 2018

Choose a reason for hiding this comment

Uh oh!

brusherru commented Oct 15, 2018

Uh oh!

cmaglie commented Oct 19, 2018

Uh oh!

ArduinoBot commented Oct 19, 2018

Uh oh!

brusherru left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

brusherru commented Oct 15, 2018 •

edited

Loading