Temporary: fix builds on dependent projects #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golang projects that uses the CLI as-a-library will fail to build because the "replace" directive is valid only for the local project. This should fix the build until GeertJohan/go.rice#159 is merged. Once the upstrea patch is merged this commit could be reverted and the fork removed.
rsora
reviewed
Sep 15, 2020
rsora
approved these changes
Sep 15, 2020
Collaborator
matthijskooijman
left a comment
matthijskooijman
left a comment
There was a problem hiding this comment.
I looked quickly, seems ok. Didn't test yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang projects that uses the CLI as-a-library will fail to build because the
replacedirective ingo.modis valid only for the local project. This should fix the build ofarduino-builderuntil GeertJohan/go.rice#159 is merged.Once the upstream patch is merged this commit could be reverted and the fork removed.