Skip to content

List/delete things/devices filtering by tags [IOT-1467] #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
polldo wants to merge 9 commits into from
Closed

List/delete things/devices filtering by tags [IOT-1467] #54

polldo wants to merge 9 commits into from

Conversation

@polldo
Copy link
Contributor

@polldo polldo commented Nov 5, 2021 •
edited
Loading

Motivation

#48 we want to list and delete things and devices based on their tags.

Change description

This PR modifies the list and delete commands:

  • list commands now accept the optional --tags flag. This parameter is then passed to the backend by the iot package.
  • delete commands now have two mutually exclusive flags --id and --tags.

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo changed the title List/delete things/devices filtering by tags List/delete things/devices filtering by tags [IOT-1467] Nov 5, 2021
@polldo polldo requested review from eclipse1985 and glumia November 5, 2021 10:38
@polldo polldo force-pushed the polldo/list-by-tags branch from 9fa2704 to f9eb9d4 Compare November 5, 2021 10:43
glumia
glumia approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@glumia glumia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions for documentation/readability improvements, overall it looks good to me!

@polldo polldo force-pushed the polldo/list-by-tags branch from 81d64d4 to 3af97f0 Compare November 8, 2021 16:34
This was referenced Nov 8, 2021
Merged
Merged
@polldo polldo mentioned this pull request Nov 22, 2021
Merged
6 tasks
@polldo polldo closed this Nov 22, 2021
@polldo polldo deleted the polldo/list-by-tags branch September 2, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@eclipse1985 eclipse1985 eclipse1985 approved these changes

@glumia glumia glumia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@polldo @eclipse1985 @glumia