Skip to content

Conversation

@polldo
Copy link
Contributor

@polldo polldo commented Dec 14, 2021

Motivation

To make user's life easier, we decided to log locations in which the configuration is searched for
When found, also the source of the configuration is logged (the exact configuration file path is logged when config is retrieved from file system)

Change description

add logs to each step of the configuration search

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested review from eclipse1985 and glumia December 14, 2021 14:25
@polldo polldo merged commit 13499b1 into main Dec 14, 2021
@polldo polldo deleted the polldo/log-config branch December 14, 2021 16:58
polldo pushed a commit that referenced this pull request Sep 2, 2022
To make user's life easier, we decided to log locations in which the configuration is searched for
polldo pushed a commit that referenced this pull request Sep 2, 2022
To make user's life easier, we decided to log locations in which the configuration is searched for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants