[skip-changelog] Correct Google TLD in certificates flash example commands
#125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommands Previously, the `arduino-fwuploader certificates flash` example commands in the command line help and "Usage" documentation used the domain `google.cc` for the download of the Google SSL certificate. Although it does work (`google.cc` redirects to `google.com`), I suspect the use of the `.cc` TLD was accidental, originating from the correct use of that TLD for the Arduino certificate domain. The commands are hereby updated to use `google.com`.
per1234
added
topic: documentation
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 10.96% 11.04% +0.08%
==========================================
Files 21 21
Lines 1805 1810 +5
==========================================
+ Hits 198 200 +2
- Misses 1549 1551 +2
- Partials 58 59 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
umbynos
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
arduino-fwuploader certificates flashexample commands in the command line help and "Usage" documentation used the domaingoogle.ccfor the download of the Google SSL certificate. Although it does work (google.ccredirects togoogle.com), I suspect the use of the.ccTLD was accidental, originating from the correct use of that TLD for the Arduino certificate domain (i.e.,arduino.cc:443).The example commands are hereby updated to use
google.com.