Fix some issues with board index generator script #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
generator.pyreplaces all the necessary parameters in theuploader.commandfield so thefwuploaderwill be able to run the upload tool, if that is not done thefwuploadersimply lacks the information necessary to replaces those parameters since they're stored in various cores'boards.txtandplatform.txt. Thefwuploaderassumes no core is installed so this had to be done.I also had to handle a corner case for the Arduino Uno WiFi Rev2 since the
upload.patternin thearduino:megaavrcore'splatform.txtalso assumes the bootloader will be uploaded, I solved this by compiling a Loader Sketch that includes the bootloader and by removing theupload.extra_filesparameter.Also I fixed all paths in the
raw_boards.jsonsince they were using my own environment paths, nowgenerator.pycan be run by anyone with ease.