Skip to content

fix 🐛 causing panic with mkr1000 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umbynos merged 1 commit into from
Jun 16, 2021
Merged

fix 🐛 causing panic with mkr1000 #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cli/certificates/flash.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ package certificates

import (
"bytes"
"fmt"
"os"
"path/filepath"
"strings"
Expand Down Expand Up @@ -161,13 +162,16 @@ func run(cmd *cobra.Command, args []string) {

// Get flasher depending on which module to use
var f flasher.Flasher
switch board.Module {
moduleName := board.Module
switch moduleName {
case "NINA":
f, err = flasher.NewNinaFlasher(address)
case "SARA":
f, err = flasher.NewSaraFlasher(address)
case "WINC":
case "WINC1500":
f, err = flasher.NewWincFlasher(address)
default:
err = fmt.Errorf("unknown module: %s", moduleName)
}
if err != nil {
feedback.Errorf("Error during certificates flashing: %s", err)
Expand Down
5 changes: 4 additions & 1 deletion cli/firmware/flash.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ package firmware

import (
"bytes"
"fmt"
"os"
"path/filepath"
"strings"
Expand Down Expand Up @@ -193,8 +194,10 @@ func run(cmd *cobra.Command, args []string) {
f, err = flasher.NewNinaFlasher(address)
case "SARA":
f, err = flasher.NewSaraFlasher(address)
case "WINC":
case "WINC1500":
f, err = flasher.NewWincFlasher(address)
default:
err = fmt.Errorf("unknown module: %s", moduleName)
}
if err != nil {
feedback.Errorf("Error during firmware flashing: %s", err)
Expand Down