Skip to content

test: run cloud sketches tests on the CI #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kittaakos merged 2 commits into from
Oct 7, 2023
Merged

test: run cloud sketches tests on the CI #2092

kittaakos merged 2 commits into from
Oct 7, 2023

Conversation

@kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Jun 8, 2023 •
edited
Loading

Motivation

Enables the Create API integration tests on the CI.

Change description

  • Made the tests more resilient,
  • Run the Create API integration tests with other slow tests,
  • Test the Create API error codes,
  • Update the workflow to run the Create API integration tests,
  • Relax the linter to ignore /lib folders.

Other information

Tests run on the CI: https://github.com/arduino/arduino-ide/actions/runs/6417438126/job/17425977420?pr=2092#step:7:649.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: cloud Related to Arduino Cloud and cloud sketches labels Jun 8, 2023
@kittaakos kittaakos self-assigned this Jun 8, 2023
kittaakos
kittaakos commented Jun 8, 2023
View reviewed changes
kittaakos
kittaakos commented Jun 8, 2023
View reviewed changes
@kittaakos kittaakos force-pushed the create-api-enhancements branch from 4c93644 to 5afbdf5 Compare June 9, 2023 07:30
@kittaakos kittaakos force-pushed the create-api-enhancements branch 2 times, most recently from 379a2e9 to f5d779a Compare October 5, 2023 08:55
@kittaakos kittaakos changed the title feat: better error handling for cloud sketches test: run cloud sketches tests on the CI Oct 5, 2023
test: run cloud sketches tests on the CI
797a937 
 - fix(test): integration tests are more resilient.
   - run the Create integration tests with other slow tests,
   - queued `PUT`/`DELETE` requests to make the test timeout happy,
   - reduced the `/sketches/search` offset to 1/5th and
   - remove Create API logging.
 - fix(linter): ignore `lib` folder. Remove obsolete `.node_modules`
pattern.
 - feat(ci): enable Create API integration tests.

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos force-pushed the create-api-enhancements branch from f5d779a to 797a937 Compare October 5, 2023 09:51
@kittaakos kittaakos marked this pull request as ready for review October 5, 2023 12:34
per1234
per1234 requested changes Oct 6, 2023
View reviewed changes
@kittaakos @per1234
Update .github/workflows/build.yml
4d58190 
Co-authored-by: per1234 <accounts@perglass.com>
@kittaakos kittaakos merged commit 0b2410d into main Oct 7, 2023
@kittaakos kittaakos deleted the create-api-enhancements branch October 7, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 approved these changes

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

Assignees

@kittaakos kittaakos

Labels

topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kittaakos @per1234