Can feed clangd with the compile commands dir. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
reviewed
Nov 4, 2020
cmaglie
approved these changes
Nov 4, 2020
If `compile-commands-dir` is not set or points to an invalid location, it is ignored. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos
force-pushed
the
compile_commands
branch
from
662ed1f to
2e949ef
Compare
silvanocerza
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
compile-commands-diris not set or points to an invalid location,it is ignored.
Signed-off-by: Akos Kitta kittaakos@typefox.io
@cmaglie, I do not know much about go, can you please review my changes. This PR supposed to pass the
compile-commands-dirargument to clangd if it is set. Thank you!