Big refactoring #38
Merged
Big refactoring #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clangd launcher has been moved into main module, removing an unneded indirection. - streams management functions now resides in their own module. - file logging has been downgraded from an object to a function
This is actually much more like a rewriting of the engine than a refactoring. Really too much stuff going on to keep track of them cleanly, a (possibly) short recap may be: - before starting clangd we make a round of arduino-preprocessing - using the new arduino-cli --only-compilation-database flag to generate both compiler flags, preprocessed sketch, etc. - multiple .ino files are now mapped into a single .cpp file - added support for clangd -query-driver flag to query cross-compiler native libraries and includes directories - using type-switch to handle messages in-out from IDE For now the LSP command partially implemented are: 'initialize' 'textDocument/didOpen'
Text versioning is not linear with the number of changes: we just use the version number passed by the client and hope for the best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.