Skip to content

Conversation

@nkaaf
Copy link
Contributor

@nkaaf nkaaf commented Jul 1, 2022

What This PR Changes

  • rename some Wi-Fi Boards to have consistent names
  • fix LoRa® / LoRaWAN® trademarks
  • fix spaces between value and unit
  • fix unit names

Contribution Guidelines

@marqdevx marqdevx self-assigned this Jul 5, 2022
@marqdevx marqdevx added fix/update A small fix or update community Bugs and fixes suggested by the community labels Jul 5, 2022
@marqdevx
Copy link
Member

marqdevx commented Jul 7, 2022

@nkaaf Please check out my suggestions 😄

@nkaaf
Copy link
Contributor Author

nkaaf commented Jul 16, 2022

Sorry for not replying to you. I was not at home last week, but I made the corrections locally. Now I have the time to push them. I thank you for your patience.

@jhansson-ard
Copy link
Collaborator

@nkaaf about the naming of the products and the Wi-Fi. The names contain the word "WiFi" as part of the name, but anywhere else when we talk about the service, we mention it as "Wi-Fi®".

About the LoRa® and LoRaWAN®, we will update them promptly, as well as the units. Thank you! ⭐

@marqdevx
Copy link
Member

marqdevx commented Aug 1, 2022

Let me fix the conflicts now 👁️
1 sec @nkaaf

@nkaaf
Copy link
Contributor Author

nkaaf commented Aug 1, 2022

Perfect, thank you! 🌟

@marqdevx marqdevx merged commit 275e41c into arduino:main Aug 1, 2022
@marqdevx
Copy link
Member

marqdevx commented Aug 1, 2022

Thank you so much for the help @nkaaf ❤️
Have a nice one!

Serjlee pushed a commit that referenced this pull request Feb 16, 2023
…gine/folder_symlinks_changes

Jcarolinares/speechrecognitionengine/folder symlinks changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Bugs and fixes suggested by the community fix/update A small fix or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants