Merged
Conversation
- Added parameter TEMP_SUFFIX to NDPluginFile parameters
- Added corresponding protected class variable NDTempSuffix
- Made necessary mods in NDPluginFile.cpp/.h
- Added records in NDFile.template
- Updated NDFileHDF5Details.edl. This included adding LazyOpen parameter
since it wasn't there yet.
* Had to overwrite the TempSufix changes to ADApp/op/edl/NDFileHDF5Details.edl as EDM files just dont merge nicely. * Resolved conflict in ADApp/pluginSrc/NDPluginFile.h as the LazyOpen parameter has since been moved elsewhere.
While doing this move, renamed the parameter from TempSuffix to FileTempSuffix as per the naming convention of file related parameters.
Now with both TempSuffix and CreateDir PVs
Now with description of the temporary suffix feature NDFileTempSuffix.
MarkRivers
added a commit
that referenced
this pull request
Jan 8, 2015
File writing with temporary suffix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a feature which was implemented April 2014 at DLS by @NicholasRees
When the temporary suffix string (NDFileTempSuffix octet parameter) is not empty it will be used as a temporary suffix on the output filename while the file is being written. When writing is complete, the file is closed and then renamed to have the suffix removed.
The rename operation is atomic from a filesystem view and can be used by monitoring applications like rsync or inotify to kick off processing applications.