This repository was archived by the owner on Aug 16, 2021. It is now read-only.
HTML5 validations support #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendjr
reviewed
Apr 22, 2017
tests/unit/react/single.js
Outdated
|
|
||
| test.deepEqual(ref.getValue(), 'Amsterdam'); | ||
|
|
||
| test.equal(el.querySelector('input').value, 'Amsterdam'); |
Owner
There was a problem hiding this comment.
You can get two more parameters in your test function: container and $. container is the el you've retrieved from the reference (or its parent, not sure by head :) and $ is actually a shortcut for container.querySelectorAll. I think it'd be nicer if you use those instead of relying on React internals.
arendjr
suggested changes
Apr 22, 2017
Owner
arendjr
left a comment
arendjr
left a comment
There was a problem hiding this comment.
Thanks! Looks like a great PR! If you can clean up those tests a little bit (not relying on React internals) I'll happily merge this!
Author
|
I've made the suggested fixes, and hope to contribute more in the future :) |
Owner
|
Great, thanks! |
arendjr
approved these changes
Apr 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are simple changes. It's about set two attributes into
inputelement. The first one isrequired, that will tell browser to check ifinputwas filled out; and the second one isvalue, that will avoid the validation error when an option is selected.More details of html5 validations: https://developer.mozilla.org/en-US/docs/Learn/HTML/Forms/Form_validation