Merged
Conversation
… installer tweaks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds clearer installer status messaging and UI tweaks across the vault setup checklist, server overlay, and server menu.
Changes:
- Add an “INSTALLING” badge animation to the vault SetupChecklist.
- Improve ServerOverlay installing-state copy with additional guidance on when the app can be closed.
- Adjust ServerMenu installer progress styling and add an explicit “Open Server Overlay” button during installation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src-vue/screens-operations/vaulting-screen/SetupChecklist.vue | Adds an “INSTALLING” badge and styling animation to the setup checklist item. |
| src-vue/overlays-operations/ServerOverlay.vue | Updates installing overlay text and adds conditional instructions about closing the app. |
| src-vue/navigation-operations/ServerMenu.vue | Refines progress label styling and changes installing menu item interaction to show a button. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <template v-if="canCloseOverlay"> | ||
| You can close this overlay and app without affect the installation process. | ||
| </template> | ||
| <template> |
There was a problem hiding this comment.
The second <template> has no v-else, so it will always render; when canCloseOverlay is true the UI will show both “you can close…” and “please do not close…”, which is contradictory. Change the second block to v-else (or v-else-if) so only one message renders.
Suggested change
| <template> | |
| <template v-else> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added installing status to vault's SetupChecklist + other small installer tweaks