Clear release requests when a bitcoin lock burns#422
Open
blakebyrnes wants to merge 1 commit intomainfrom
Open
Clear release requests when a bitcoin lock burns#422blakebyrnes wants to merge 1 commit intomainfrom
blakebyrnes wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that when a Bitcoin lock is burned (due to expiration or being spent), any pending release request is cleared so associated “pending cosign” tracking is also removed, and it extends existing tests to cover these burn paths.
Changes:
- Clear
LockReleaseRequestsByUtxoId(and related cosign tracking) duringburn_bitcoin_lock. - Extend expiration and “spent” tests to create a pending release request and assert the pending cosign state is removed when the lock burns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
pallets/bitcoin_locks/src/lib.rs |
Clears pending release requests during lock burn via take_release_request. |
pallets/bitcoin_locks/src/tests.rs |
Adds coverage for expiration/spent burn paths with a pending release request and checks storage cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When a bitcoin lock burns with a pending release request, clear the request and burn the held release funds. Cover the spent path in the existing bitcoin lock tests.
8afeaf5 to
6ae276e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Testing