Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

cronworkflows status can contains empty values#36

Open
duduz wants to merge 1 commit intoargoproj-labs:masterfrom
duduz:cronflowstatus_none_fix
Open

cronworkflows status can contains empty values#36
duduz wants to merge 1 commit intoargoproj-labs:masterfrom
duduz:cronflowstatus_none_fix

Conversation

@duduz
Copy link
Copy Markdown

@duduz duduz commented Jun 15, 2021

While this is not ideal in any way, the purpose of this PR is strictly to provide a working solution for cronworkflows for those who seeks it.

  1. Cronworkflows functionality is pretty much limited at the moment (5.0.0) due to certain values being retuned as None as in the response when creating a cronworkflow, this response is being handled by the V1alpha1CronWorkflowStatus model.
  2. Having nulls in the response is fine and that's an expected behavior when the created cronworkflow doesn't have that information yet.
  3. This sceanrio is not covered by the model, therefore, any newly created cronworkflow or a querying for cronworkflow that didn't execute yet will result in ValueError exception.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant