Skip to content

Conversation

@jparsai
Copy link
Collaborator

@jparsai jparsai commented Nov 29, 2024

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:
This PR is to add logic to configure RespectRBAC feature from Argo CD resource. Now users can configure value in ConfigMap via argocd.spec.controller.respectRBAC field.

Which issue(s) this PR fixes:
RH issue tracker :- https://issues.redhat.com/browse/GITOPS-5955

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @jparsai! I have one suggestion around moving the doc content to another page, then good to go.

Signed-off-by: Jayendra Parsai <jparsai@jparsai-thinkpadp1gen4i.remote.csb>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks again @jparsai!

@jgwest jgwest merged commit 28659bf into argoproj-labs:master Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants