Add default health value in CM to get Health status in the Application CR #1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rizwana777
force-pushed
the
issue-7009-healt-status
branch
2 times, most recently
from
d0756a4 to
9af3000
Compare
Rizwana777
force-pushed
the
issue-7009-healt-status
branch
from
9af3000 to
aa53ba4
Compare
svghadi
approved these changes
Jun 26, 2025
Collaborator
svghadi
left a comment
svghadi
left a comment
There was a problem hiding this comment.
LGTM. Thanks @Rizwana777
Rizwana777
force-pushed
the
issue-7009-healt-status
branch
from
aa53ba4 to
edb315c
Compare
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Rizwana777
force-pushed
the
issue-7009-healt-status
branch
3 times, most recently
from
abef716 to
c484a31
Compare
…n CR Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Rizwana777
force-pushed
the
issue-7009-healt-status
branch
from
c484a31 to
e325cf3
Compare
svghadi
approved these changes
Jun 26, 2025
jgwest
approved these changes
Jul 2, 2025
Member
jgwest
left a comment
jgwest
left a comment
There was a problem hiding this comment.
LGTM too, thanks @Rizwana777 and thanks @svghadi for reviewing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://issues.redhat.com/browse/GITOPS-7009
Steps to test -
Update this value to ArgoCD version 3.0.0
then apply :
apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
name: example-argocd
spec:
cmdParams:
controller.resource.health.persist: "true"
Create an Application CR to see the CR status of application is working as expected