fix: avoid short names in deployment manifests

[sbose78]

• Using short names is subject to the risk of hitting squatted registry namespaces
• If a user's configuration is set to pull images from somewhere other then Dockerhub, the user may unknowingly pull a malicious image.

possibly part of argoproj/argoproj#40

Signed-off-by: Shoubhik Bose shbose@redhat.com

Checklist:

• My organization is added to USERS.md.

[codecov]

Codecov Report

Merging #5475 (669f1c5) into master (5bd7ce8) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 669f1c5 differs from pull request most recent head e39bce3. Consider uploading reports for the commit e39bce3 to get more accurate results

@@            Coverage Diff             @@
##           master    #5475      +/-   ##
==========================================
- Coverage   16.49%   16.48%   -0.01%     
==========================================
  Files         243      243              
  Lines       43774    43774              
==========================================
- Hits         7219     7217       -2     
- Misses      35573    35575       +2     
  Partials      982      982              

Impacted Files	Coverage Δ
workflow/metrics/server.go	12.76% <0.00%> (-4.26%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd7ce8...e39bce3. Read the comment docs.

[wanghong230]

Based on the team's decision, we plan to switch to quay.io. Could you help change to quay.io?

[sbose78]

Thanks, I wasn't aware if we wanted to modify manifests right away. I'll PR for sure
https://quay.io/repository/argoproj/workflow-controller?tab=tags