Skip to content

fix(controller): Only set global parameters after workflow validation succeeded to avoid panics#5477

Merged
alexec merged 1 commit into
argoproj:masterfrom
terrytangyuan:dev-test-unsupplied-param
Mar 22, 2021
Merged

fix(controller): Only set global parameters after workflow validation succeeded to avoid panics#5477
alexec merged 1 commit into
argoproj:masterfrom
terrytangyuan:dev-test-unsupplied-param

Conversation

@terrytangyuan
Copy link
Copy Markdown
Member

Fixes #5473.

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Checklist:

… succeeded

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan changed the title fix(controller): Only set global parameters after workflow validation succeeded fix(controller): Only set global parameters after workflow validation succeeded to avoid panics Mar 22, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 22, 2021

Codecov Report

Merging #5477 (95b35aa) into master (5bd7ce8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 95b35aa differs from pull request most recent head 1abdccc. Consider uploading reports for the commit 1abdccc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5477      +/-   ##
==========================================
- Coverage   16.49%   16.46%   -0.03%     
==========================================
  Files         243      243              
  Lines       43774    43775       +1     
==========================================
- Hits         7219     7208      -11     
- Misses      35573    35587      +14     
+ Partials      982      980       -2     
Impacted Files Coverage Δ
workflow/controller/operator.go 70.53% <100.00%> (+0.01%) ⬆️
workflow/metrics/server.go 12.76% <0.00%> (-4.26%) ⬇️
server/workflow/workflow_server.go 40.45% <0.00%> (-2.28%) ⬇️
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd7ce8...1abdccc. Read the comment docs.

@alexec alexec merged commit 513756e into argoproj:master Mar 22, 2021
@terrytangyuan terrytangyuan deleted the dev-test-unsupplied-param branch March 22, 2021 18:38
@simster7 simster7 mentioned this pull request Mar 22, 2021
34 tasks
simster7 pushed a commit that referenced this pull request Mar 23, 2021
… succeeded to avoid panics (#5477)

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@simster7 simster7 mentioned this pull request Mar 29, 2021
77 tasks
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workflow controller panics when workflow parameter was not supplied

3 participants