fix(ui): Multiple UI fixes#5498
Merged
Merged
Conversation
Signed-off-by: Simon Behar <simbeh7@gmail.com>
simster7
commented
Mar 23, 2021
Comment on lines
+111
to
+112
| selectedPhases: phaseQueryParam.length > 0 ? (phaseQueryParam as WorkflowPhase[]) : savedOptions.selectedPhases, | ||
| selectedLabels: labelQueryParam.length > 0 ? (labelQueryParam as string[]) : savedOptions.selectedLabels, |
alexec
approved these changes
Mar 23, 2021
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #5498 +/- ##
==========================================
- Coverage 46.66% 46.64% -0.03%
==========================================
Files 240 240
Lines 14985 14985
==========================================
- Hits 6993 6990 -3
- Misses 7093 7094 +1
- Partials 899 901 +2
Continue to review full report at Codecov.
|
simster7
commented
Mar 23, 2021
| return 'redirect=' + urlParams.get('redirect'); | ||
| } | ||
| return ''; | ||
| return 'redirect=' + window.location.origin + '/workflows'; |
alexec
approved these changes
Mar 23, 2021
simster7
added a commit
that referenced
this pull request
Mar 23, 2021
Signed-off-by: Simon Behar <simbeh7@gmail.com>
This was referenced Mar 29, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5496
Fixes #5494