Skip to content

fix(server): Disable CN check (Go 15 does not support). Fixes #5539#5550

Merged
alexec merged 1 commit into
masterfrom
dev-crt
Mar 30, 2021
Merged

fix(server): Disable CN check (Go 15 does not support). Fixes #5539#5550
alexec merged 1 commit into
masterfrom
dev-crt

Conversation

@alexec
Copy link
Copy Markdown
Contributor

@alexec alexec commented Mar 30, 2021

No description provided.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec added this to the v3.0 milestone Mar 30, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2021

Codecov Report

Merging #5550 (60a6cda) into master (4c3b0ac) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 60a6cda differs from pull request most recent head 62ad166. Consider uploading reports for the commit 62ad166 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5550      +/-   ##
==========================================
- Coverage   46.97%   46.95%   -0.02%     
==========================================
  Files         240      240              
  Lines       15011    15011              
==========================================
- Hits         7051     7048       -3     
- Misses       7060     7066       +6     
+ Partials      900      897       -3     
Impacted Files Coverage Δ
server/workflow/workflow_server.go 40.45% <0.00%> (-2.28%) ⬇️
cmd/argo/commands/get.go 56.66% <0.00%> (ø)
workflow/controller/operator.go 70.96% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3b0ac...62ad166. Read the comment docs.

@alexec alexec marked this pull request as ready for review March 30, 2021 20:15
@alexec alexec requested a review from whynowy March 30, 2021 20:15
@alexec
Copy link
Copy Markdown
Contributor Author

alexec commented Mar 30, 2021

@whynowy can I please request your review?

@alexec alexec merged commit 20f0047 into master Mar 30, 2021
@alexec alexec deleted the dev-crt branch March 30, 2021 22:34
simster7 pushed a commit that referenced this pull request Mar 31, 2021
…5550)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
simster7 added a commit to simster7/argo that referenced this pull request Apr 1, 2021
simster7 added a commit to simster7/argo that referenced this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error to access UI using port-forward

2 participants