feat: Add support to auto-mount service account tokens for plugins.#8176
Merged
alexec merged 4 commits intoargoproj:masterfrom Mar 22, 2022
Merged
feat: Add support to auto-mount service account tokens for plugins.#8176alexec merged 4 commits intoargoproj:masterfrom
alexec merged 4 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Member
crenshaw-dev
left a comment
crenshaw-dev
left a comment
There was a problem hiding this comment.
Looks good. I'd recommend adding some docs: 1) why/how to use this and 2) "please please please only do this if necessary and then limit permissions carefully".
Contributor
|
will this be merged at v3.3.2? |
terrytangyuan
approved these changes
Mar 22, 2022
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
Mar 23, 2022
…rgoproj#8176) Signed-off-by: Alex Collins <alex_collins@intuit.com>
Contributor
|
why this feature note picked in v3.3.2 or 3.3.3 waiting for long times. because my volcano plugin rely on it. @sarabala1979 |
whybeyoung
pushed a commit
to whybeyoung/argo-workflows
that referenced
this pull request
Apr 27, 2022
…rgoproj#8176) Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
added a commit
that referenced
this pull request
Apr 27, 2022
…8176) Signed-off-by: Alex Collins <alex_collins@intuit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins alex_collins@intuit.com
Users have requested a couple of times the ability to access the Kuberenetes API. This uses the same pattern as PodSpec.AutomountServiceAccountToken, but the name of the service account is fixed.