Skip to content

Conversation

@gaelreyrol
Copy link
Contributor

@gaelreyrol gaelreyrol commented Nov 29, 2023

Hi @arnaud-lb,

In this PR,

I updated actions version, macos runner version and added new matrix xdebug version parameter.

Would you allow workflows without approvals so I can adapt this PR and make sure it's working before making it ready to review?

@arnaud-lb
Copy link
Owner

I've temporarily allowed workflows to run without approval

I like the proposed changes except for the single quotes thing, as YAML has tricky ways to interpret unquoted strings. I prefer to quote by default to avoid surprises.

@gaelreyrol gaelreyrol marked this pull request as ready for review November 29, 2023 10:18
@arnaud-lb arnaud-lb merged commit b02c754 into arnaud-lb:v3 Nov 29, 2023
@arnaud-lb
Copy link
Owner

Thank you!

@gaelreyrol gaelreyrol deleted the update-ci-workflows branch November 29, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants