Skip to content

fix some bugs#102

Closed
fehiepsi wants to merge 1 commit intoarokem:masterfrom
fehiepsi:master
Closed

fix some bugs#102
fehiepsi wants to merge 1 commit intoarokem:masterfrom
fehiepsi:master

Conversation

@fehiepsi
Copy link

This pull request fixes some syntax errors for building 'messenger.mexa' file.

@arokem
Copy link
Owner

arokem commented Dec 26, 2014

Hi! Thanks for doing this - to understand these errors: what version of python and what OS are you working on?

@fehiepsi
Copy link
Author

Dear @arokem, I am using win xp 32bit with python 3.4.
The first bug is file object not having decode() method. The second is missing a space. The third and the forth is subprocess.Popen().stdout returning byte stream instead of text stream, unless we change the universal_newlines argument in method Popen() into True.

@arokem
Copy link
Owner

arokem commented Dec 27, 2014

I am worried that these changes will not work on python 2, and I would like
to keep support for python 2 as well. Have not had the opportunity to test
this on python 2 yet. Give me a couple of days to do that.

On Sat, Dec 27, 2014 at 4:43 AM, fehiepsi notifications@github.com wrote:

Dear @arokem https://github.com/arokem, I am using win xp 32bit with
python 3.4.
The first bug is file object not having decode() method. The second is
missing a space. The third and the forth is subprocess.Popen().stdout
returning byte stream instead of text stream, unless we change the
universal_newlines argument in method Popen() into True.


Reply to this email directly or view it on GitHub
#102 (comment)
.

@arokem
Copy link
Owner

arokem commented Jan 24, 2015

Sorry for not picking this up before. I think that this was all addressed in #112. Let me know if I can close this. Thanks!

@arokem arokem closed this Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants