Skip to content

Minor mex make fixes#111

Closed
jakirkham wants to merge 4 commits intoarokem:masterfrom
jakirkham:minor-mex-make-fixes
Closed

Minor mex make fixes#111
jakirkham wants to merge 4 commits intoarokem:masterfrom
jakirkham:minor-mex-make-fixes

Conversation

@jakirkham
Copy link
Contributor

No description provided.

… it's win32, it won't be one of the others. Closes arokem#110.
…g file, the full path to the file must be specified. Closes arokem#109.
…losing the file. This is better for error handling should it be required. Closes arokem#107.
@arokem
Copy link
Owner

arokem commented Jan 24, 2015

This is much needed. However, it's not working on python3. I am still trying to make this work for python3 and will merge as soon as I can make it go.

@jakirkham
Copy link
Contributor Author

What's the error that you are getting? I don't have a working copy of python3 on hand.

@arokem arokem mentioned this pull request Jan 24, 2015
@arokem
Copy link
Owner

arokem commented Jan 24, 2015

Please take a look here: #112 - it integrates my python 3 fixes, on top of your commits. Does this look good to you?

@jakirkham
Copy link
Contributor Author

Yep, works fine for me. I was wondering if it was an encoding issue.

@jakirkham jakirkham closed this Jan 24, 2015
@jakirkham
Copy link
Contributor Author

Closed in favor of #112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants