Skip to content

More streamlining, fault tolerance, and coverage increasing#142

Merged
isbadawi merged 18 commits intoarokem:masterfrom
blink1073:increase-coverage
Feb 16, 2015
Merged

More streamlining, fault tolerance, and coverage increasing#142
isbadawi merged 18 commits intoarokem:masterfrom
blink1073:increase-coverage

Conversation

@blink1073
Copy link
Collaborator

@blink1073 blink1073 commented Feb 16, 2015

87 -> 92%, and caught some bugs!

isbadawi
isbadawi reviewed Feb 16, 2015
View reviewed changes
pymatbridge/pymatbridge.py Outdated
Copy link
Collaborator

@isbadawi isbadawi Feb 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pragma, not pramga

arokem
arokem reviewed Feb 16, 2015
View reviewed changes
pymatbridge/matlab_magic.py
Copy link
Owner

@arokem arokem Feb 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably safer to use IPython.version_info

Copy link
Collaborator Author

@blink1073 blink1073 Feb 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed any more, I used a version-agnostic method.

Copy link
Owner

@arokem arokem Feb 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes. This is red. Silly me.

@isbadawi
Copy link
Collaborator

isbadawi commented Feb 16, 2015

There seems to be an issue with the Travis build. If the tests fail, it waits for 10 minutes and times out.

@blink1073
Copy link
Collaborator Author

blink1073 commented Feb 16, 2015

@isbadawi, yeah, I'm not sure what to do about that. The Python 3.4 version had the same behavior even when passing.

@blink1073
Copy link
Collaborator Author

blink1073 commented Feb 16, 2015

We could add a kill switch alarm to make it stop sooner...

@blink1073
Copy link
Collaborator Author

blink1073 commented Feb 16, 2015

Oh great, now they are all hanging...

@arokem
Copy link
Owner

arokem commented Feb 16, 2015

It looks like the test failure leaves it hanging there.

On Mon, Feb 16, 2015 at 9:57 AM, Steven Silvester notifications@github.com
wrote:

Oh great, now they are all hanging...

—
Reply to this email directly or view it on GitHub
#142 (comment)
.

@blink1073
Copy link
Collaborator Author

blink1073 commented Feb 16, 2015

Hold on before merging, I'm adding two more tests.

@blink1073
Copy link
Collaborator Author

blink1073 commented Feb 16, 2015

The hanging behaviour was a result of me removing __del__ in the magic without putting the explicit stop() call back in unload_ipython_extension. Fixed now, and ready to merge!

isbadawi added a commit that referenced this pull request Feb 16, 2015
@isbadawi
Merge pull request #142 from blink1073/increase-coverage
3b7024a 
More streamlining, fault tolerance, and coverage increasing
@isbadawi isbadawi merged commit 3b7024a into arokem:master Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blink1073 @isbadawi @arokem