Streamline build process to use a single make and config file#144
Streamline build process to use a single make and config file#144isbadawi merged 9 commits intoarokem:masterfrom
Conversation
|
LGTM. You should be able to delete |
messenger/make.py
Outdated
messenger/make.py
Outdated
There was a problem hiding this comment.
With the quotes around the executable I get an OSError: [Errno 2] No such file or directory on my mac.
There was a problem hiding this comment.
Hmm, looking at the original version it looks like those quotes were there. But yeah I got the same error on Linux with Matlab (must be a windows-only thing).
There was a problem hiding this comment.
Probably just os.system has different semantics than check_output.
There was a problem hiding this comment.
Ah, you reminded me to use shlex.split, which will handle spaces in paths.
There was a problem hiding this comment.
And yes, that does make sense, since we are passing a list of strings.
messenger/make.py
Outdated
There was a problem hiding this comment.
I still get an error here when building for matlab. I ran the mex command manually and it looks like I don't get a .o file anywhere, actually.
Streamline build process to use a single make and config file
2 participants
No description provided.