Conversation
|
Ugh I hate you Coveralls! |
|
Do not merge yet! I have to change messenger.c again. |
|
Good to go. Octave plots were coming back from the dead so I had to add an explicit |
|
Sorry, please wait again. |
|
Nevermind, I tried to avoid closing the figures by using |
|
Just to be sure - these newly compiled messengers are now compiled against zmq 4? |
|
I compiled against libzmq3, since that is what is available via |
|
I went in the coveralls settings and changed "Coverage decrease threshold for failure" to "10%", so (if I understand the setting correctly) it should stop failing PRs for reducing coverage by a tiny amount like this. (You should both have access if you'd like to mess with the settings more: https://coveralls.io/r/arokem/python-matlab-bridge). Anyway, this LGTM. I'll commit new versions of the OS X messengers for Matlab and Octave (built against v4) after merging. |
|
Cool cool. I am working on setting up the messengers right now, so you can On Fri, Feb 20, 2015 at 5:15 PM, Ismail Badawi notifications@github.com
|
|
Oh sorry! I just pushed them. Feel free to override if you have something you want to add. |
|
No problem. The ones you pushed are compiled against zmq 4? I'll add (as On Fri, Feb 20, 2015 at 5:17 PM, Ismail Badawi notifications@github.com
|
|
Yep, I built them against 4.0.5. |
|
OK. Working on those zmq3 messngers for the mac. Will have a PR with that On Fri, Feb 20, 2015 at 5:21 PM, Ismail Badawi notifications@github.com
|
|
I should build some zmq 4 ones for linux as well. — On Fri, Feb 20, 2015 at 8:24 PM, Ariel Rokem notifications@github.com
|
Make the
messengernon-blocking, and allow Matlab GUI to refresh, making visible plots interactive.Added the ability to toggle visibility through the
set_plot_settingsmethod or using the--guiflag in the magic. The Matlab splash screen will now pop up at the start, but the figures are invisible by default.Also fixes a bug where "clear all" killed the Server.
Finally, adds numpy as a dependency.
Tested with both Matlab and Octave in Linux.
Fixes #101. Fixes #70. Fixes #148. Fixes #96. Fixes #99. Fixes #132.