fix messenger build on windows

[aebrahim]

No description provided.

[arokem]

Thanks for doing this! I think that the test breakage is fixed here:

#162

So let's merge that one first, and then rebase this one on top of it, before merging it as well.

[arokem]

This seems like it might be confusing. If someone enters a typo, it will try to build the octave thing and emit a confusing error. How about:

elif args.target == 'octave':
    build_octave
else: 
    e_s = "'%s' is not a valid target for building the messenger."%args.target
    e_s = e_s + " Use 'matlab' or 'octave'" 
    raise ValueError(e_s)

Or something to that effect. Also, could you please rebase on master? Thanks!

[aebrahim]

It won't let you choose another one because argparse limits the choices.

for example, running ./make.py foo will give:
usage: make.py [-h] [--static] {matlab,octave}
make.py: error: argument target: invalid choice: 'foo' (choose from
'matlab', 'octave')

On Mon, Mar 9, 2015 at 7:54 PM, Ariel Rokem notifications@github.com
wrote:

In messenger/make.py
#161 (comment)
:

 else:

•    print(usage)
  

•    build_octave()
  

This seems like it might be confusing. If someone enters a typo, it will
try to build the octave thing and emit a confusing error. How about:

elif args.target == 'octave':
build_octave
else:
e_s = "'%s' is not a valid target for building the messenger."%args.target
e_s = e_s + " Use 'matlab' or 'octave'"
raise ValueError(e_s)

Or something to that effect. Also, could you please rebase on master?
Thanks!

—
Reply to this email directly or view it on GitHub
https://github.com/arokem/python-matlab-bridge/pull/161/files#r26095797.

[aebrahim]

I'll still change it though... it is your repo after all :)

On Mon, Mar 9, 2015 at 8:01 PM, Ali Ebrahim aebrahim@ucsd.edu wrote:

It won't let you choose another one because argparse limits the choices.

for example, running ./make.py foo will give:
usage: make.py [-h] [--static] {matlab,octave}
make.py: error: argument target: invalid choice: 'foo' (choose from
'matlab', 'octave')

On Mon, Mar 9, 2015 at 7:54 PM, Ariel Rokem notifications@github.com
wrote:

In messenger/make.py
#161 (comment)
:

 else:

•    print(usage)
  

•    build_octave()
  

This seems like it might be confusing. If someone enters a typo, it will
try to build the octave thing and emit a confusing error. How about:

elif args.target == 'octave':
build_octave
else:
e_s = "'%s' is not a valid target for building the messenger."%args.target
e_s = e_s + " Use 'matlab' or 'octave'"
raise ValueError(e_s)

Or something to that effect. Also, could you please rebase on master?
Thanks!

—
Reply to this email directly or view it on GitHub
https://github.com/arokem/python-matlab-bridge/pull/161/files#r26095797
.

[arokem]

Gotcha. No need to change - I just really didn't know how that works. I see the whole thing above now. Cool. Thanks for doing this - much cleaner.

[aebrahim]

Should be good to go

[arokem]

Thanks!