Fix matlabserver shutdown behavior#169
Merged
arokem merged 1 commit intoarokem:masterfrom Apr 24, 2015
Merged
Conversation
Owner
|
Whoops. Sorry that it's taken so long to look at this. Looks good! |
arokem
added a commit
that referenced
this pull request
Apr 24, 2015
Fix matlabserver shutdown behavior
Collaborator
|
@blink1073 Can you explain why I ask because it looks like Octave doesn't like you calling |
Collaborator
Author
|
@isbadawi, it was needed to make sure Matlab actually shut down. |
Collaborator
Author
|
You could try wrapping it in a try block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #168, addresses #164.
I could not find a way to reliably interrupt the Matlab process and recover from it, but at least now Ctrl+C results in a clean shutdown of the Matlab process.