Fix some warnings in MATLAB code.#83
Merged
arokem merged 3 commits intoarokem:masterfrom Aug 27, 2014
isbadawi:misc-cleanup
Merged
Fix some warnings in MATLAB code.#83arokem merged 3 commits intoarokem:masterfrom isbadawi:misc-cleanup
arokem merged 3 commits intoarokem:masterfrom
isbadawi:misc-cleanup
Conversation
The path to test_sum.m was wrong. It still works because run_func works by adding the directory to the path and then calling the function; the addpath fails with a warning, but test_sum.m is on the path anyway because it's under matlab/.
This fixes some warnings on Octave. (Also update the docs for pymat_eval, which were still describing web_eval).
There's no need for this indirection since we know which function we're calling.
Owner
|
yep - all good. |
Collaborator
Author
|
Ping -- can you merge this? |
Owner
|
Oops. I thought I already did. Thanks for the reminder. |
arokem
added a commit
that referenced
this pull request
Aug 27, 2014
Fix some warnings in MATLAB code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are just a couple of things I ran into while working on Octave support.
is_function_processor_working-- it was trying to calladdpathon a path that doesn't exist. The function still worked because everything undermatlab/is on the path anyway.feval(str2func('f'), ...)instead of just directly callingf(...).