_Session.set_variable for ndarray and spmatrix#85
Merged
arokem merged 2 commits intoarokem:masterfrom Aug 29, 2014
aebrahim:set_variable
Merged
_Session.set_variable for ndarray and spmatrix#85arokem merged 2 commits intoarokem:masterfrom aebrahim:set_variable
arokem merged 2 commits intoarokem:masterfrom
aebrahim:set_variable
Conversation
This function will correctly serialize numpy arrays as json due to customizations to the JSON encoder. Additionally, this function will handle scipy sparse matrices as well. The matlab magic now calls this function. This commit *DOES NOT* add any new dependencies to numpy and scipy, and the code should function as normal without them.
Owner
There was a problem hiding this comment.
Yep - this all seems OK to me. Hard to imagine anyone would want to use this without numpy/scipy, but it's good not to require that.
This is needed when generating temporary variables for transferring a sparse matrix.
Contributor
Author
|
I updated the pull request to use uuid4 instead |
arokem
added a commit
that referenced
this pull request
Aug 29, 2014
_Session.set_variable for ndarray and spmatrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function will correctly serialize numpy arrays as json due to
customizations to the JSON encoder. Additionally, this function will
handle scipy sparse matrices as well.
The matlab magic now calls this function.
This commit DOES NOT add any new dependencies to numpy and scipy, and
the code should function as normal without them.