Skip to content

Kellyroach/upgrade to xcode10#2

Open
kellyroach wants to merge 5 commits intoarpitjain03:masterfrom
kellyroach:kellyroach/upgrade-to-xcode10
Open

Kellyroach/upgrade to xcode10#2
kellyroach wants to merge 5 commits intoarpitjain03:masterfrom
kellyroach:kellyroach/upgrade-to-xcode10

Conversation

@kellyroach
Copy link
Copy Markdown

@kellyroach kellyroach commented Sep 29, 2018

This pull request updates AJParticlesLoadingView to Xcode 10 / Swift 4.2 .

  • Add .gitignore
  • Update to Xcode 10 / Swift 4.2
  • Main.storyboard constraints improved.
  • "Universal" to get better demo app appearance on iPad.
  • START/STOP was always the same demo: heart - Fireflies .
    Revised demo app btnClicked chooses particle image and effect at random for
    more variety.
  • START/STOP button background is now green/red .
  • Rotating demo app to landscape looks OK enough.
  • Deployment Target = 8.0
  • Added AppIcon to demo app.

UPDATE: We've added another commit that moves the ambition of the P.R. back a bit
to Xcode 9, 9.3 / Swift 4.0 support. We're still hitting most of the bullet points listed
in the P.R. description above.

@arpitjain03
Copy link
Copy Markdown
Owner

Hi Kelly,
I will highly appreciate the work you have done for my library.
But the changes you have made, giving error in Xcode 9.4.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants