Skip to content

Fixed regression from 0.14.0#599

Merged
systemcatch merged 3 commits intoarrow-py:masterfrom
jadchaar:emergency-fix
Jun 3, 2019
Merged

Fixed regression from 0.14.0#599
systemcatch merged 3 commits intoarrow-py:masterfrom
jadchaar:emergency-fix

Conversation

@jadchaar
Copy link
Member

@jadchaar jadchaar commented Jun 3, 2019

@systemcatch @crsmithdev we need to get this patch pushed ASAP since a recent change broke the install.

Fixes: #598

This other PR I am working on should prevent such as issue from coming up in the future: #597

@codecov-io
Copy link

Codecov Report

Merging #599 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #599   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines        1501   1501           
  Branches      225    225           
=====================================
  Hits         1501   1501

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfafc0e...9d52ef3. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #599 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #599   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines        1501   1501           
  Branches      225    225           
=====================================
  Hits         1501   1501

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfafc0e...fa4f2e4. Read the comment docs.

Copy link

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jadchaar
Copy link
Member Author

jadchaar commented Jun 3, 2019

Proof of fix:

  1. Screen Shot 2019-06-03 at 1 29 19 AM
  2. The updated setup.py plays well with Tox now in this PR: Updated tox file and changed Travis CI to use tox #597 (Tox uses the packaged version of arrow to run tests).

@systemcatch systemcatch self-requested a review June 3, 2019 09:06
Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear, I wonder why that breakage wasn't caught by the tests.

@systemcatch systemcatch merged commit f77546d into arrow-py:master Jun 3, 2019
@asottile
Copy link

asottile commented Jun 3, 2019

Oh dear, I wonder why that breakage wasn't caught by the tests.

the good news is @jadchaar is setting up tox which will catch packaging issues like this in the future 🎉 (#597)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup.py is trying to import dependencies which aren't yet installed

4 participants