Skip to content

Fix missing error check in set_clo_on_exec for FD_CLOEXEC handling #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arun11299 merged 1 commit into from
Apr 28, 2025
Merged

Fix missing error check in set_clo_on_exec for FD_CLOEXEC handling #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions subprocess.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,10 +471,14 @@ namespace util
void set_clo_on_exec(int fd, bool set = true)
{
int flags = fcntl(fd, F_GETFD, 0);
if (flags == -1) {
throw OSError("fcntl F_GETFD failed", errno);
}
if (set) flags |= FD_CLOEXEC;
else flags &= ~FD_CLOEXEC;
//TODO: should check for errors
fcntl(fd, F_SETFD, flags);
if (fcntl(fd, F_SETFD, flags) == -1) {
throw OSError("fcntl F_SETFD failed", errno);
}
}


Expand Down