Skip to content

fix: Replication status messages in objects #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lfbrehm merged 1 commit into from
Jan 24, 2024
Merged

fix: Replication status messages in objects #106

lfbrehm merged 1 commit into from
Jan 24, 2024

Conversation

@lfbrehm
Copy link
Member

@lfbrehm lfbrehm commented Jan 23, 2024

Summary

This fixes an inheritance issue emerging from explicitly stating IDs in variant for DataEndpoint.

Consequences

  • Updating relations no longer requires updating every object with a new Origin Id inside variant.
  • Only one status for endpoint and resource can be set

@lfbrehm lfbrehm requested review from St4NNi and das-Abroxas January 23, 2024 15:56
@lfbrehm lfbrehm merged commit 4d973a1 into main Jan 24, 2024
@St4NNi
Copy link
Member

St4NNi commented Jan 24, 2024

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@das-Abroxas das-Abroxas Awaiting requested review from das-Abroxas

@St4NNi St4NNi Awaiting requested review from St4NNi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lfbrehm @St4NNi