Skip to content

Conversation

@das-Abroxas
Copy link
Contributor

@das-Abroxas das-Abroxas commented Jun 28, 2024

This pull request introduces enhancements to the API for public announcements within the StorageStatusService by extending the Announcement message with the following fields:

  • announcement_type: A non-exhaustive type to differentiate announcements
  • title: A title for the announcement
  • teaser: A short summary of the announcement
  • created_by: An id or display name of the original author
  • modified_by: An id or display name of the last person that modified the announcement
  • modified_at: Timestamp of the last modification

In addition, the StorageStatusService gets extended by the following

  • Extended endpoint GetAnnouncements with an optional id filter
  • New endpoint GetAnnouncement, which enables the specific query of an announcement based on its id
  • New endpoint GetAnnouncementsByType, which enables to query all announcements of a specific type
  • Pagination for all StorageStatusService GET Requests

These extensions will offer users of the API more flexibility in how they can display public announcements, regardless of whether it's just a small timeline or a proper blog.

@das-Abroxas das-Abroxas added the enhancement New feature or request label Jun 28, 2024
@das-Abroxas das-Abroxas self-assigned this Jun 28, 2024
@das-Abroxas das-Abroxas removed the request for review from Stefan-JLU June 28, 2024 19:08
@St4NNi St4NNi self-requested a review July 1, 2024 07:44
Copy link
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im fine with this now!

LGTM !

@das-Abroxas das-Abroxas requested a review from St4NNi July 1, 2024 12:21
Copy link
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@das-Abroxas das-Abroxas merged commit 969380d into main Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants